Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python environment and version metadata to benchmark results #476

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

fabianliebig
Copy link
Collaborator

Hello everyone,

this pull request aims to include the current Python environment data and version to the result, storing them as part of the JSON file.

I look forward to your feedback.

@fabianliebig fabianliebig self-assigned this Feb 5, 2025
@fabianliebig fabianliebig marked this pull request as draft February 5, 2025 17:35
@fabianliebig fabianliebig force-pushed the feat/bechmark/add_python_env_data branch 2 times, most recently from c811a36 to bf95854 Compare February 5, 2025 17:55
@fabianliebig fabianliebig marked this pull request as ready for review February 5, 2025 17:56
Copy link
Collaborator

@Scienfitz Scienfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warrants a small CHANGELOG entry

@AdrianSosic AdrianSosic force-pushed the feat/bechmark/add_python_env_data branch from 7caaeb8 to 2aaf3a5 Compare February 6, 2025 12:09
Copy link
Collaborator

@AdrianSosic AdrianSosic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fabianliebig, thx for the quick implementations. I've refined the attribute definitions a little bit but all looking good 👍🏼

@AdrianSosic AdrianSosic merged commit 55425de into main Feb 6, 2025
8 of 11 checks passed
@AdrianSosic AdrianSosic deleted the feat/bechmark/add_python_env_data branch February 6, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants