Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pareto optimization #475
base: main
Are you sure you want to change the base?
Pareto optimization #475
Changes from 44 commits
bdd1e90
5e52039
460bbc1
04056ee
8b2d199
6788abb
1043156
473ac15
41542f1
d0d7716
75be534
0e340e5
12eef75
0f29bda
1081ce7
262392f
d9d8541
42273de
44b605d
b9bc60c
7b97131
eb6aad6
9cf8363
5795a4a
f4384bd
1fd25e9
0c605b8
81bf88c
f3e5c57
3b41310
3deee1b
0252ef0
26c7e36
d22bdac
3e867d2
966cfd7
43872a2
c157d01
3383fd9
5918719
727ac31
d124ffd
78fee0c
b3b77fb
dc3d601
f8b6b61
ec9570f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
detached comment 3: working with Pareto I think the
Campaign.posterior
call is much more important and probaly part fo the workflow (to check the target predictions and possibly make a subchoice of poitns to evaluate on the predicted frontier). Imo this then should be mentioned both in the UG and in the example (albeit briefy, jsut referencing theposterior
method and explaiing why its useful for that)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followup: for the API as well as less experienced users, it might be useful to have a posterior method or any other convenience object that returns a dataframe with targets, mean and var of posterior prediction, and not a posterior object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.