-
-
Notifications
You must be signed in to change notification settings - Fork 408
Deprecate Ember Proxies #1112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Deprecate Ember Proxies #1112
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
--- | ||
stage: accepted | ||
start-date: 2025-06-13T00:00:00.000Z | ||
release-date: | ||
release-versions: | ||
teams: # delete teams that aren't relevant | ||
- cli | ||
- data | ||
- framework | ||
- learning | ||
- steering | ||
- typescript | ||
prs: | ||
accepted: https://github.com/emberjs/rfcs/pull/1112 | ||
project-link: | ||
--- | ||
|
||
<!--- | ||
Directions for above: | ||
|
||
stage: Leave as is | ||
start-date: Fill in with today's date, 2032-12-01T00:00:00.000Z | ||
release-date: Leave as is | ||
release-versions: Leave as is | ||
teams: Include only the [team(s)](README.md#relevant-teams) for which this RFC applies | ||
prs: | ||
accepted: Fill this in with the URL for the Proposal RFC PR | ||
project-link: Leave as is | ||
--> | ||
|
||
# Deprecating Ember Proxies | ||
|
||
## Summary | ||
|
||
Now that Native Proxy is available in all supported environments, we can deprecate | ||
Ember's custom Proxy handling provided by `ArrayProxy`, `ObjectProxy`, and `PromiseProxyMixin`. | ||
|
||
## Motivation | ||
|
||
These patterns were introduce to Ember prior to the availability of Native Proxy. Since | ||
Native Proxy is now available in all supported environments, we can deprecate these | ||
patterns in favor of the native Proxy API. | ||
|
||
Additionally, we would like to deprecate Mixins in the future necessitating that we first | ||
deprecate `PromiseProxyMixin`. | ||
|
||
## Transition Path | ||
|
||
There is no direct migration path for these. Code that relies upon this behavior will have to be rewritten. | ||
NullVoxPopuli marked this conversation as resolved.
Show resolved
Hide resolved
kategengler marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
See the deprecation guide (PR'd here: https://github.com/ember-learn/deprecation-app/pull/1405 ) | ||
|
||
## Exploration | ||
|
||
To validate this deprecation, I've tried removing the assocaited functionality in this PR: | ||
https://github.com/emberjs/ember.js/pull/20918 | ||
|
||
## How We Teach This | ||
|
||
We should remove references to these patterns from the guides. | ||
|
||
## Drawbacks | ||
|
||
By not providing a direct replacement some users may have difficulty migrating. | ||
|
||
## Alternatives | ||
|
||
None | ||
|
||
## Unresolved questions | ||
|
||
None |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.