Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ember-best-practices-build/test-cases.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"ruleId": "",
"ruleTitle": "Form Labels and Error Announcements",
"type": "good",
"code": "// app/components/form.gjs\n<template>\n <form {{on \"submit\" this.handleSubmit}}>\n <div>\n <label for=\"email-input\">\n Email Address\n {{#if this.isEmailRequired}}\n <span aria-label=\"required\">*</span>\n {{/if}}\n </label>\n\n <input\n id=\"email-input\"\n type=\"email\"\n value={{this.email}}\n {{on \"input\" this.updateEmail}}\n aria-describedby={{if this.emailError \"email-error\"}}\n aria-invalid={{if this.emailError \"true\"}}\n required={{this.isEmailRequired}}\n />\n\n {{#if this.emailError}}\n <span id=\"email-error\" role=\"alert\" aria-live=\"polite\">\n {{this.emailError}}\n </span>\n {{/if}}\n </div>\n\n <button type=\"submit\" disabled={{this.isSubmitting}}>\n {{#if this.isSubmitting}}\n <span aria-live=\"polite\">Submitting...</span>\n {{else}}\n Submit\n {{/if}}\n </button>\n </form>\n</template>",
"code": "// app/components/form.gjs\n<template>\n <form {{on \"submit\" this.handleSubmit}}>\n <div>\n <label for=\"email-input\">\n Email Address\n <span aria-hidden=\"true\">*</span>\n </label>\n\n <input\n id=\"email-input\"\n type=\"email\"\n value={{this.email}}\n {{on \"input\" this.updateEmail}}\n aria-describedby={{if this.emailError \"email-error\"}}\n aria-invalid={{if this.emailError \"true\"}}\n required={{this.isEmailRequired}}\n />\n\n {{#if this.emailError}}\n <span id=\"email-error\" role=\"alert\" aria-live=\"polite\">\n {{this.emailError}}\n </span>\n {{/if}}\n </div>\n\n <button type=\"submit\" disabled={{this.isSubmitting}}>\n {{#if this.isSubmitting}}\n <span aria-live=\"polite\">Submitting...</span>\n {{else}}\n Submit\n {{/if}}\n </button>\n </form>\n</template>",
"language": "glimmer-js",
"description": "with labels and announcements"
},
Expand Down
4 changes: 1 addition & 3 deletions skills/ember-best-practices/AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -3441,9 +3441,7 @@ All form inputs must have associated labels, and validation errors should be ann
<div>
<label for="email-input">
Email Address
{{#if this.isEmailRequired}}
<span aria-label="required">*</span>
{{/if}}
<span aria-hidden="true">*</span>
</label>

<input
Expand Down
4 changes: 1 addition & 3 deletions skills/ember-best-practices/rules/a11y-form-labels.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@ All form inputs must have associated labels, and validation errors should be ann
<div>
<label for="email-input">
Email Address
{{#if this.isEmailRequired}}
<span aria-label="required">*</span>
{{/if}}
<span aria-hidden="true">*</span>
</label>

<input
Expand Down
Loading