Skip to content

Update loading spinner component to glimmer #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 18, 2022
Merged

Update loading spinner component to glimmer #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a4b5960
loading-spinner: convert to glimmer
geneukum Jul 23, 2022
4e8df39
loading-spinner: prefer single quotes
geneukum Jul 23, 2022
1e9d9cf
tests: loading-spinner: prefer angle bracket syntax
geneukum Jul 23, 2022
79fa0a0
Merge branch 'master' into update-loading-spinner-component-to-glimmer
geneukum Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions app/components/loading-spinner.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<div class='loading-spinner'>
<div class='sk-folding-cube'>
<div class='sk-cube1 sk-cube'></div>
<div class='sk-cube2 sk-cube'></div>
<div class='sk-cube4 sk-cube'></div>
<div class='sk-cube3 sk-cube'></div>
</div>
{{yield}}
</div>
5 changes: 0 additions & 5 deletions app/components/loading-spinner.js
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions app/templates/components/loading-spinner.hbs
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions tests/integration/components/loading-spinner-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@ module('Integration | Component | loading spinner', function (hooks) {
// Set any properties with this.set('myProperty', 'value');
// Handle any actions with this.on('myAction', function(val) { ... });

await render(hbs`{{loading-spinner}}`);
await render(hbs`<LoadingSpinner/>`);

assert.dom('*').hasText('');

// Template block usage:
await render(hbs`
{{#loading-spinner}}
<LoadingSpinner>
template block text
{{/loading-spinner}}
</LoadingSpinner>
`);

assert.dom('*').hasText('template block text');
Expand Down