Fixed quickrun duplicating the source buffer on multiple runs#94
Open
pickardjoe wants to merge 4 commits intoemacsorphanage:masterfrom
Open
Fixed quickrun duplicating the source buffer on multiple runs#94pickardjoe wants to merge 4 commits intoemacsorphanage:masterfrom
pickardjoe wants to merge 4 commits intoemacsorphanage:masterfrom
Conversation
jcs090218
reviewed
Nov 25, 2020
Collaborator
jcs090218
left a comment
jcs090218
left a comment
There was a problem hiding this comment.
Minor review.
Sorry for the late review! 😅
| "Kill quickrun buffer." | ||
| (when (get-buffer quickrun--buffer-name) | ||
| (kill-buffer quickrun--buffer-name))) | ||
| (let (quickrun--buffer (get-buffer quickrun--buffer-name)) |
Collaborator
There was a problem hiding this comment.
I think there is a syntax error over here? Can you check this? Thanks!
Collaborator
There was a problem hiding this comment.
How come this patch works? The variable quickrun--buffer will always return nil hence it will never run. 😕
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #75.