Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more explicit about waiting for the fetch process #73

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Be more explicit about waiting for the fetch process #73

merged 3 commits into from
Jan 10, 2025

Conversation

snogge
Copy link
Collaborator

@snogge snogge commented Dec 17, 2024

Explicitly wait for the process returned by magit-fetch instead of relying on the magit-this-process variable.

@snogge
Use with-temp-message in some patchset functions
157935a 
Change magit-gerrit-view-patchset-diff and
magit-gerrit-download-patchset to use `with-temp-message' while
waiting for the gerrit process to complete.

Let the message functions do the format operation.
@snogge
Let magit-gerrit-process-wait wait on any process
ce9f2f1 
Still defaults to magit-this-process.
@snogge
Wait on fetch in magit-gerrit-(download|view)-patchset*
da82d36 
Explicitly tell magit-gerrit-process-wait which process to wait for.
@snogge
Copy link
Collaborator Author

snogge commented Dec 17, 2024

I'll leave this open for comments for a few days before merging.

@snogge snogge merged commit 07307db into emacsorphanage:master Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@snogge