feat: add additional LSP support for YAML by adding helm-ls support #4665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
client
Aaronzinhoo
changed the title
jcs090218
approved these changes
Jan 4, 2025
|
LGTM. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for YAML helm-ls to provide more targeted features when editing Helm
Charts and template files.
helm-lsstarts a helm language server and conditionally starts a yaml-language-server which means a lot of configuration for this client is duplicated with theyaml-language-serverclient inlsp-yaml.el. The implementation supports all of the helm specific configuration settings and the priority has been set to 0 for now since no major mode will activate thehelm-lsserver. This means users would need to make their own major mode and update thelsp-language-id-configurationsettings accordingly to make it usable for now.I hope to make another PR here soon when I finish the minimal major mode for helm specific template files that I have been using to test with! Although
helm-lsseems like a superset of the capabilities offered byyaml-language-serverI would think its main purpose would editing kubernetes and helm / helmfile templated files specifically which would allow adding some tailoring and customizations that eventually diverge from the more generic yaml client! Open to ideas / thoughts here and any changes needed to get this through!Happy holidays everyone!