Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a solidity language server #4208

Merged
merged 2 commits into from
Oct 30, 2023
Merged

feat: Add a solidity language server #4208

merged 2 commits into from
Oct 30, 2023

Conversation

Konubinix
Copy link
Contributor

  • I added a new entry to CHANGELOG.md

  • I updated documentation if applicable (docs folder)

@github-actions github-actions bot added documentation client One or more of lsp-mode language clients labels Oct 28, 2023
Following the example of bash-lsp.

Also, don't confuse the user by telling about alternative
implementations, while this package was mostly tested with the
implementation of nomicfoundation.
@Konubinix
Copy link
Contributor Author

By looking at the code of lsp-bash.el I realized that I could automate the download of the language server. I did that is a separate commit.

@jcs090218
Copy link
Member

LGTM.

@yyoncho
Copy link
Member

yyoncho commented Oct 30, 2023

Thank you for contributing to lsp-mode!

@yyoncho yyoncho merged commit 291f730 into emacs-lsp:master Oct 30, 2023
12 of 14 checks passed
@Konubinix
Copy link
Contributor Author

Konubinix commented Oct 31, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client One or more of lsp-mode language clients documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants