Allow clients to specify code action arguments where nil values should be treated as :json-false #4194
Conversation
robbert-vdh
changed the title
lsp-mode.el
Outdated
| (lsp-put structure key :json-false))) | ||
| ;; If `key' does not exist, then we'll silently ignore it | ||
| (when-let ((child (lsp-get structure key))) | ||
| (lsp--fix-nested-boolean child rest)))) |
There was a problem hiding this comment.
I'm not very familiar with elisp and its data structures, so maybe there's an existing/better combinator for doing deep queries/updates in nested hash tables.
robbert-vdh
force-pushed
the
robbert-vdh/patch-boolean-action-values
branch
from
85d97a5 to
54b971e
Compare
|
Thank you for your PR. I would like the implementation to be changed a bit. In this PR the client is supposed to use some description of the fixes to be applied which may or may not cover all cases. (e. g. it may depend on more context and so on). So instead of having the logic here in lsp-mode I would like to be pushed into the client. That can happen if lsp-mode receives a function from the client and then only applies it to the result. |
|
Sorry, I completely forgot about this PR! I was originally intending to do that but then I thought I'd just make the API simpler since this is the thing you'd most likely want to hotpatch. I'll change this PR to defer the modifications/filtering to a function, and to just provide a library function that does this specific modification instead. |
This lets us fix emacs-lsp#4184 by selectively changing `nil` code action argument values to `:json-false`. Once this is merged, HLS needs to set the field to `'(:withSig)` (and possibly some other values).
robbert-vdh
force-pushed
the
robbert-vdh/patch-boolean-action-values
branch
from
54b971e to
d74c7bd
Compare
|
Updated the PR so the client can now define an arbitrary function to modify code action requests before they are sent back to the server. I'll update the |
This lets us fix #4184 by selectively changing
nilcode action argument values to:json-false. Once this is merged, HLS needs to set the field to'(:withSig)(and possibly some other values).Some possible alternatives to this would be to:
boolean-action-argumentsinto an alist that matches (part of) the command's name. This needs to support partial matches because HLS includes a plugin ID in the command name, and these are not guaranteed to stay constant.Supersedes #4191.