Fixed project submission form redirect #20
+83
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1514395049
💛 - Coveralls |
elric97
reviewed
Nov 30, 2021
| import TextField from "@mui/material/TextField"; | ||
| import Button from '@mui/material/Button'; | ||
| import Service from "../Service"; | ||
| import FilledInput from '@mui/material/FilledInput'; |
Owner
There was a problem hiding this comment.
Codacy has a fix for the issue: Strings must use doublequote.
Suggested change
| import FilledInput from '@mui/material/FilledInput'; | |
| import FilledInput from "@mui/material/FilledInput"; |
elric97
reviewed
Nov 30, 2021
| import Button from '@mui/material/Button'; | ||
| import Service from "../Service"; | ||
| import FilledInput from '@mui/material/FilledInput'; | ||
| import InputAdornment from '@mui/material/InputAdornment'; |
Owner
There was a problem hiding this comment.
Codacy has a fix for the issue: Strings must use doublequote.
Suggested change
| import InputAdornment from '@mui/material/InputAdornment'; | |
| import InputAdornment from "@mui/material/InputAdornment"; |
elric97
reviewed
Nov 30, 2021
| import Service from "../Service"; | ||
| import FilledInput from '@mui/material/FilledInput'; | ||
| import InputAdornment from '@mui/material/InputAdornment'; | ||
| import FormControl from '@mui/material/FormControl'; |
Owner
There was a problem hiding this comment.
Codacy has a fix for the issue: Strings must use doublequote.
Suggested change
| import FormControl from '@mui/material/FormControl'; | |
| import FormControl from "@mui/material/FormControl"; |
elric97
reviewed
Nov 30, 2021
| fullWidth | ||
| id="filled-basic" | ||
| variant="filled" | ||
| style={{ color:'#218888'}} |
Owner
There was a problem hiding this comment.
Codacy has a fix for the issue: Strings must use doublequote.
Suggested change
| style={{ color:'#218888'}} | |
| style={{ color:"#218888"}} |
elric97
reviewed
Nov 30, 2021
| import { ReactSession } from "react-client-session"; | ||
| import styled from "styled-components"; | ||
| import TextField from "@mui/material/TextField"; | ||
| import Button from '@mui/material/Button'; |
Owner
There was a problem hiding this comment.
Codacy has a fix for the issue: Strings must use doublequote.
Suggested change
| import Button from '@mui/material/Button'; | |
| import Button from "@mui/material/Button"; |
elric97
reviewed
Nov 30, 2021
|
|
||
| <button data-testid="submit_button" onClick={handleSubmit}>Submit</button> | ||
| <br /><br /> | ||
| <Button variant="contained" size="large" data-testid="submit_button" onClick={()=>{handleSubmit();handleRoute()}} > |
Owner
There was a problem hiding this comment.
Codacy has a fix for the issue: Missing semicolon.
Suggested change
| <Button variant="contained" size="large" data-testid="submit_button" onClick={()=>{handleSubmit();handleRoute()}} > | |
| <Button variant="contained" size="large" data-testid="submit_button" onClick={()=>{handleSubmit();handleRoute();}} > |
elric97
reviewed
Nov 30, 2021
|
|
||
| <button data-testid="submit_button" onClick={handleSubmit}>Submit</button> | ||
| <br /><br /> | ||
| <Button variant="contained" size="large" data-testid="submit_button" onClick={()=>{handleSubmit();handleRoute()}} > |
Owner
There was a problem hiding this comment.
Codacy has a fix for the issue: Missing space before =>.
Suggested change
| <Button variant="contained" size="large" data-testid="submit_button" onClick={()=>{handleSubmit();handleRoute()}} > | |
| <Button variant="contained" size="large" data-testid="submit_button" onClick={() =>{handleSubmit();handleRoute()}} > |
elric97
reviewed
Nov 30, 2021
|
|
||
| const history=useHistory(); | ||
|
|
||
| const handleRoute = () =>{ |
Owner
There was a problem hiding this comment.
Codacy has a fix for the issue: Missing space after =>.
Suggested change
| const handleRoute = () =>{ | |
| const handleRoute = () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.