Correction of state inversion in switches #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When switch is paired to zigate you could request manufacturer info. Easier solution might be to add configuration parameter for inverting ON and OFF states. Other good solution could be adding manufacturer and model parameters to config and using them on code. I don't have aquara push button either, but https://zigate.fr/xiaomi-bouton-switch-cluster/ shows that 00 is ON and 01 is OFF. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why you've choose to flag state ON with 00 and OFF with 01 initially but this does not work with xiaomi wall switch connected to light (see https://community.home-assistant.io/t/new-custom-component-zigate/36820/282?u=biau )
With this changes wall switch works fine but I do not have aqara push button to see if this brake something.
I did not find any attribute value in the zigbee message to differentiate switches types.