Normalize schema #3
Open
+3,047
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Rationale Provide a better automated method of mapping to a known and set schema version for when this audit parser is written for. Also enables direct interaction with the schema definition
### Rationale Schema might of included this at one point in the past but currently in version 14, the instances parameter is invalid for when parsing `npm audit --json` output v1
### Rationale Given that this library requires a file from the module, it needs to be a dependency.
### Rationale The top level version is actually there to define the schema this output adheres to. Subsequently to maintain the differentiator of the npm audit version that is now appended to the scanner name field. These changes apply to both formats.
### Rationale With the new changes to normalize the schema, the snapshots had to be updated to pass the test cases.
### Rationale Need to maintain simplicity and lightweight use of package but now have more dependencies so webpack will save the day
### Rationale Configured to extract only used files, minify and mangle into a final shell runnable script Overall, this maintains the simplicity and lightweight use of package after adding more dependencies
### Rationale Define the use of webpacking the code through npm pkg run-scripts
### Rationale Simplify duplicate options
### Rationale Prepare script is not desired to run on end user machine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improve ease of maintenance and integration with official schema for which this repo is designed around while maintaining the lightweight production use.
Summary of Fixes
How to Verify
NOTE: Conflicts with PR #2 as I built this one on an independent branch and unfortunately the run-scripts cause a git conflict. Depending if #2 is accepted or not, will adjust either PR to work with the new master branch. I built them independently to provide you a choice if you would like to merge the features or not.