Fix incorrect linkedEditingRange triggers #1364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should be fast enough IMO. also makes it sound, like that should be expected - I usually end up using rename in vscode, so I'm unsure, what's expected here/what other lsps do |
SomeoneToIgnore
pushed a commit
to zed-industries/zed
that referenced
this pull request
Apr 24, 2025
The known issue with `linked_edits` seems to be fixed in this PR: elm-tooling/elm-language-server#1364. This PR removes the section from Zeds documentation to avoid confusion. Release Notes: - Remove known issues section from Elm documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1311.
The only problem I've encountered so far is that when I type a bit faster, the two lines go out of sync. I'm assuming this is a limitation of the LSP, but I might be mistaken.
P.S. I believe there is a way to make linked editing even better. Instead of just linking the type annotation and the value declaration, we could use references to modify all the instances of the identifier in the document at once. This might be slow, though. WDYT?