Add clang-tidy support #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotgoodrich
force-pushed
the
clang-tidy
branch
25 times, most recently
from
678b51f to
9d12a56
Compare
Add a CMake option `ENABLE_CLANG_TIDY` to enable `clang-tidy` for the project. This is enabled on Linux only in the Github runners since it is the only image that has `clang-tidy` installed by default. I have disabled any check that didn't seem to improve the code. The only code that was exempt and should be fixed is the recursive function calls in `trimutil.cpp` triggered by `misc-no-recursion`. I think fixing them should be done separately to avoid an overly complex commit.
elliotgoodrich
force-pushed
the
clang-tidy
branch
from
9d12a56 to
5214ebe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a CMake option
ENABLE_CLANG_TIDYto enableclang-tidyfor theproject.
This is enabled on Linux only in the Github runners since it is the only
image that has
clang-tidyinstalled by default.I have disabled any check that didn't seem to improve the code. The
only code that was exempt and should be fixed is the recursive function
calls in
trimutil.cpptriggered bymisc-no-recursion. I thinkfixing them should be done separately to avoid an overly complex commit.