Skip to content

Laravel 12#20

Merged
ellgreen merged 2 commits intomainfrom
laravel-12
Feb 28, 2025
Merged

Laravel 12#20
ellgreen merged 2 commits intomainfrom
laravel-12

Conversation

@ellgreen
Copy link
Copy Markdown
Owner

This pull request includes several updates to dependencies, testing tools, and code formatting. The most important changes include updating the PHP and Laravel versions, switching testing and linting tools, and various code and configuration file adjustments.

Dependency and version updates:

  • composer.json: Updated PHP requirement to ^8.2 and illuminate/database to ^12.0, and replaced phpunit with pest.
  • .github/workflows/test.yml: Updated PHP versions to include 8.4 and Laravel versions to 12.*.

Testing and linting tools:

Code and configuration adjustments:

Documentation and settings:

  • README.md: Updated the required PHP and Laravel versions.
  • .zed/settings.json: Added folder-specific settings for JSON files with a tab size of 4.

@ellgreen ellgreen requested a review from Copilot February 28, 2025 10:26
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This pull request updates the project to support Laravel 12 with updated PHP version requirements and testing/linting tools.

  • Updated testing commands and matrix configurations in .github/workflows/test.yml to replace PHPUnit/PHPCS with Pest/Pint.
  • Updated dependency and version specifications in composer.json and documentation in README.md.
  • Updated docker-compose.yml to enforce MySQL version 8.0.

Reviewed Changes

File Description
.github/workflows/test.yml Updated testing command (Pest) and matrix configuration for PHP/Laravel
README.md Revised required PHP and Laravel versions
docker-compose.yml Changed MySQL image version to 8.0

Copilot reviewed 36 out of 36 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

.github/workflows/test.yml:16

  • [nitpick] Replacing PHPCS with Pint means coding standards enforcement now relies on Pint. Please confirm that a proper Pint configuration file (e.g., .pint.json) exists and is aligned with the project’s style requirements.
      - run: vendor/bin/pint --test

.github/workflows/test.yml:31

  • The testing matrix now includes PHP 8.4 along with Laravel 12. Ensure that all dependencies and tests are fully compatible with PHP 8.4 to avoid unexpected behavior.
        php: [8.2, 8.3, 8.4]

@ellgreen ellgreen merged commit 7415d36 into main Feb 28, 2025
@ellgreen ellgreen deleted the laravel-12 branch February 28, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants