Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support 'annual_report' notification type #3084

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Dec 9, 2024

Mastodon

Screenshot of Mastodon notification page writes "Your 2024 #Wrapstodon awaits! Unveil your year's highlights and memorable moments on Mastodon! View #Wrapstodon"

Elk

The new notification will be rendered like this:

Screenshot of Elk notification page writes "Your 2024 #Wrapstodon awaits! Unveil your year's highlights and memorable moments on Mastodon! View #Wrapstodon on Mastodon"

<article flex="" flex-col="" relative="" hover:bg-active="" border="b base">
  <div flex="" p4="" items-center="" bg-shaded="">
    <div i-mdi:party-popper="" text-xl="" me-4="" color-purple=""></div>
    <div class="content-rich">
      <p> Your 2024 <a href="/tags/Wrapstodon" class="">#Wrapstodon</a> awaits! Unveil your year's highlights and memorable moments on Mastodon! </p>
      <p><a href="https://mastodon.social/notifications" rel="noopener noreferrer" target="_blank">View #Wrapstodon on Mastodon</a></p>
    </div>
  </div>
</article>

The summary panel seems to be rendered within Mastodon's client and there is no URL for the card, so I put an external link to Mastodon's notification page.

@shuuji3 shuuji3 requested a review from ayoayco December 9, 2024 08:17
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 2727ceb
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/675bfb023d3ea00008895db4

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 2727ceb
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/675bfb028987d80008a0c515
😎 Deploy Preview https://deploy-preview-3084--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@patak-dev
Copy link
Member

Looks great!

@patak-dev patak-dev added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit fb411e8 Dec 13, 2024
17 checks passed
@patak-dev patak-dev deleted the shuuji3/feat/annual-report branch December 13, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants