-
Notifications
You must be signed in to change notification settings - Fork 4
switch from lite-api to api.jup.ag with API key auth #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.x
Are you sure you want to change the base?
Changes from 42 commits
c81e5eb
5e6e90e
345694b
b1d3cca
39e6d9e
15a2f0d
c363fe3
6a39d05
b340047
eb9b8f7
3a92fa5
e5f1783
5e307f3
3d612d1
b96c223
cc89e9a
8c5ad9e
d092fc7
6e91857
8d2c795
e2cc8a7
0420f53
a2afcae
7acad24
6635c26
a165741
23f355b
0b483bc
e0faefd
13c0efc
5c48223
9165b3b
34afa9f
dd69ab0
3d87234
c5e0291
72918ae
b981558
a8b1ac2
1eec39d
5617683
5937f13
b4bb982
10ceeb5
76b34ae
5607b40
46cebf5
3ee6a9e
bcf47d8
63de337
7887e1b
661ee72
9df7759
59cab4c
fbad91a
7d64671
0079fc5
eca87f2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,44 @@ | ||
| # Dependencies | ||
| node_modules | ||
|
|
||
| # Build outputs | ||
| dist | ||
| node_modules | ||
| build | ||
| *.tsbuildinfo | ||
| .turbo | ||
| .turbo-tsconfig.json | ||
|
|
||
| # Environment files | ||
| .env | ||
| .env.local | ||
| .env.production | ||
| .env.bak | ||
|
|
||
| # IDE | ||
| .idea | ||
| .vscode | ||
| .zed | ||
| .DS_Store | ||
|
|
||
| # Test coverage | ||
| coverage | ||
| .nyc_output | ||
|
|
||
| # Logs | ||
| *.log | ||
| logs | ||
|
|
||
| # Cache | ||
| cache | ||
| .cache | ||
| tokencache | ||
|
|
||
| # Temporary files | ||
| *.tmp | ||
| *.temp | ||
| .tmp | ||
|
|
||
| # Bundler artifacts | ||
| tsup.config.bundled_*.mjs | ||
| # prr state file (auto-generated) | ||
| .pr-resolver-state.json |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # PRR Lessons Learned | ||
|
|
||
| > This file is auto-generated by [prr](https://github.com/elizaOS/prr). | ||
| > It contains lessons learned from PR review fixes to help improve future fix attempts. | ||
| > You can edit this file manually or let prr update it. | ||
| > To share lessons across your team, commit this file to your repo. | ||
| ## File-Specific Lessons | ||
|
|
||
| ### src/service.ts | ||
|
|
||
| - Fix for src/service.ts:679 - The review rejects changing return types to match current behavior — it demands restoring the historical API or renaming to reflect actual functionality. | ||
| - Fix for src/service.ts:679 - The diff renamed getCurrentPrices to getHistoricalPrices but didn't preserve a getCurrentPrices method—must add new method instead of renaming existing one. | ||
| - Fix for src/service.ts:679 - The diff must show the OLD broken implementation at lines 650-679 being replaced/removed, not just ADD a new method elsewhere. | ||
| - Fix for src/service.ts:679 - The new throwing method was added but the old broken implementation at lines 669-690 wasn't removed — need to replace the existing method body, not add a duplicate method definition below it. | ||
| - Fix for src/service.ts:695 - The review asks to fix the bug in `getHistoricalPrices` (lines 614-625), not replace it with a stub that throws an error. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| #!/usr/bin/env bun | ||
| import { $ } from "bun"; | ||
|
|
||
| async function build() { | ||
| const totalStart = Date.now(); | ||
| const pkg = await Bun.file("package.json").json(); | ||
| const externalDeps = [ | ||
| ...Object.keys(pkg.dependencies ?? {}), | ||
| ...Object.keys(pkg.peerDependencies ?? {}), | ||
| ]; | ||
| const isWatch = process.argv.includes("--watch"); | ||
odilitime marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| // Use the clean script from package.json | ||
| if (pkg.scripts?.clean) { | ||
| console.log("🧹 Cleaning..."); | ||
| await $`bun run clean`.quiet(); | ||
| } | ||
|
|
||
| const esmStart = Date.now(); | ||
| console.log("🔨 Building @elizaos/plugin-jupiter..."); | ||
| const esmResult = await Bun.build({ | ||
| entrypoints: ["src/index.ts"], | ||
| outdir: "dist", | ||
| target: "node", | ||
| format: "esm", | ||
| sourcemap: "external", | ||
| minify: false, | ||
| external: externalDeps, | ||
| watch: isWatch, | ||
| }); | ||
| if (!esmResult.success) { | ||
| console.error(esmResult.logs); | ||
| throw new Error("ESM build failed"); | ||
| } | ||
| console.log(`✅ Build complete in ${((Date.now() - esmStart) / 1000).toFixed(2)}s`); | ||
|
|
||
| const dtsStart = Date.now(); | ||
| console.log("📝 Generating TypeScript declarations..."); | ||
| try { | ||
| await $`bun run tsc --project tsconfig.build.json`; | ||
| console.log(`✅ Declarations generated in ${((Date.now() - dtsStart) / 1000).toFixed(2)}s`); | ||
| } catch (error: any) { | ||
| console.error(`❌ TypeScript declaration generation failed (${((Date.now() - dtsStart) / 1000).toFixed(2)}s)`); | ||
| if (error?.stderr) console.error(error.stderr.toString()); | ||
| throw new Error("Declaration generation failed"); | ||
| } | ||
cursor[bot] marked this conversation as resolved.
Show resolved
Hide resolved
cursor[bot] marked this conversation as resolved.
Show resolved
Hide resolved
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| console.log(`🎉 All builds finished in ${((Date.now() - totalStart) / 1000).toFixed(2)}s`); | ||
| } | ||
|
|
||
| build().catch((err) => { | ||
| console.error("Build failed:", err); | ||
| process.exit(1); | ||
| }); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,16 +4,19 @@ | |
| "main": "dist/index.js", | ||
| "type": "module", | ||
| "types": "dist/index.d.ts", | ||
| "engines": { | ||
| "bun": ">=1.0.0" | ||
| }, | ||
| "dependencies": { | ||
| "@elizaos/core": "^1.0.0", | ||
| "@elizaos/plugin-solana": "^1.0.0-beta.51" | ||
| }, | ||
| "devDependencies": { | ||
| "tsup": "^8.3.5" | ||
| "typescript": "^5.0.0" | ||
| }, | ||
| "scripts": { | ||
| "build": "tsup --format esm --dts", | ||
| "dev": "tsup --format esm --dts --watch", | ||
| "build": "bun run build.ts", | ||
| "dev": "bun --watch run build.ts", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Dev watch mode never activates for source filesMedium Severity The Additional Locations (1) |
||
| "clean": "rm -rf dist", | ||
| "lint": "prettier --write ./src" | ||
| }, | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-generated review tool state committed to repo
Low Severity
The
.prr/lessons.mdfile contains auto-generated debugging notes from the PRR review tool, describing specific failed fix attempts with line numbers and review interactions (e.g., "The new throwing method was added but the old broken implementation at lines 669-690 wasn't removed"). These context-specific tool outputs are confusing to future developers and add noise to the repository.