Skip to content

fix(pdf): keep paragraph breaks in complete extraction and document info #36675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wddygybw wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(pdf): keep paragraph breaks in complete extraction and document info #36675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions plugins/plugin-pdf/services/pdf.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import { parsePdfSpecDate } from "./pdf-date.js";

type PdfTextItem = {
str: string;
hasEOL?: boolean;
transform?: unknown;
width?: unknown;
height?: unknown;
Expand All @@ -51,15 +52,15 @@ function isTextItem(item: unknown): item is PdfTextItem {
);
}

function collectTextStrings(items: unknown): string[] {
function collectTextStrings(items: unknown, lineSeparator = ""): string[] {
if (!Array.isArray(items)) {
throw new TypeError("PDF text content items must be an array");
}

const textItems: string[] = [];
for (const item of items) {
if (isTextItem(item)) {
textItems.push(item.str);
textItems.push(item.str + (item.hasEOL ? lineSeparator : ""));
}
}
return textItems;
Expand Down Expand Up @@ -268,7 +269,11 @@ export class PdfService extends Service {
const page = await pdf.getPage(pageNumber);
const viewport = page.getViewport({ scale: 1 });
const textContent = await page.getTextContent();
const nativeText = this.cleanUpContent(collectTextStrings(textContent.items).join(" "));
// A text item is one font run, not one word: a run boundary is not a word
// boundary. Only the parser end-of-line flag ends a line.
const nativeText = this.cleanUpContent(
collectTextStrings(textContent.items, "\n").join("")
);
const nativePositionedText = collectPositionedTextItems(textContent.items, pageNumber);
const operatorList = await page.getOperatorList();
if (!Array.isArray(operatorList.fnArray)) {
Expand Down Expand Up @@ -521,7 +526,7 @@ export class PdfService extends Service {
const viewport = page.getViewport({ scale: 1.0 });
const textContent = await page.getTextContent();

const pageText = collectTextStrings(textContent.items).join(" ");
const pageText = collectTextStrings(textContent.items, "\n").join("");

pages.push({
pageNumber: pageNum,
Expand Down