Make map/array encoding configurable #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warmwaffles
approved these changes
Mar 19, 2025
|
Yea this looks great! |
warmwaffles
reviewed
Mar 19, 2025
lib/ecto/adapters/sqlite3.ex
Outdated
| storage format. | ||
| * `:array_type` - Defaults to `:string`. Determines the type of `:array` columns. | ||
| Arrays are serialized using JSON. Set to `:binary` to use the | ||
| [JSONB](https://sqlite.org/draft/jsonb.html) storage format. |
There was a problem hiding this comment.
Suggested change
| [JSONB](https://sqlite.org/draft/jsonb.html) storage format. | |
| [JSONB](https://sqlite.org/jsonb.html) storage format. |
warmwaffles
reviewed
Mar 19, 2025
lib/ecto/adapters/sqlite3.ex
Outdated
| Possible values and column types are the same as for | ||
| [binary IDs](#module-binary-id-types). | ||
| * `:map_type` - Defaults to `:string`. Determines the type of `:map` columns. | ||
| Set to `:binary` to use the [JSONB](https://sqlite.org/draft/jsonb.html) |
There was a problem hiding this comment.
Let's point at the official docs and not the draft.
Suggested change
| Set to `:binary` to use the [JSONB](https://sqlite.org/draft/jsonb.html) | |
| Set to `:binary` to use the [JSONB](https://sqlite.org/jsonb.html) |
There was a problem hiding this comment.
Oops I missed that, fixed!
a-nassim
force-pushed
the
configurable-map-encoding
branch
from
d21f7f4 to
ffeaeff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #162
This PR adds:
:map_typeconfig option to determine how:mapcolumns are stored (:stringor:binary):array_typeconfig option for:arraycolumns (also:stringor:binary):arraycolumns are also serialized using JSONBoth default to
:string, the:binaryoption enables SQLite's JSONB storage format.I tried to be consistent with other configurable types in this project like
:uuidthat is why it is not implemented the exact same way as in the Postgres adapter.