-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to pyproject.toml #251
base: dev
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request migrates the project to use Sequence diagram for GitHub Actions CI workflowsequenceDiagram
participant GH Actions
participant Poetry
participant flake8
participant mypy
participant pytest
GH Actions->>Poetry: Install dependencies
Poetry-->>GH Actions: Dependencies installed
GH Actions->>flake8: Run linting
flake8-->>GH Actions: Linting results
GH Actions->>mypy: Run type checking
mypy-->>GH Actions: Type checking results
GH Actions->>pytest: Run tests
pytest-->>GH Actions: Test results
Updated class diagram for project dependenciesclassDiagram
class pyproject.toml {
-build-system
-tool.poetry
-dependencies
-python
-addict
-celery
-connexion
-cryptography
-Flask
-flask-authz
-Flask-Cors
-Flask-PyMongo
-pydantic
-PyJWT
-pymongo
-PyYAML
-requests
-swagger-ui-bundle
-toml
-typing
-Werkzeug
-group.code_quality.dependencies
-flake8
-Flake8-pyproject
-mypy
-mypy-extensions
-pylint
-group.docs.dependencies
-Sphinx
-readthedocs-sphinx-ext
-sphinx-rtd-theme
-group.test.dependencies
-coverage
-mongomock
-pytest
-group.types.dependencies
-types-PyYAML
-types-requests
-types-setuptools
-types-urllib3
-typing_extensions
}
note for pyproject.toml "Replaces requirements.txt and setup.py for dependency management"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JaeAeich - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a
poetry.lock
file to the repository to ensure consistent dependency versions across environments. - The removal of
setup.py
andrequirements.txt
is expected, but double-check that all references to these files have been removed from other parts of the project.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #251 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 966 969 +3
=========================================
+ Hits 966 969 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
migrate to using pyproject instead of setuptools.
Fixes #232
Summary by Sourcery
Migrates the project to use
pyproject.toml
and Poetry for dependency management and build configuration. This includes updating the Dockerfile, CI workflow, and development scripts to use Poetry, as well as removing obsolete files and adding a Makefile for common development tasks.Enhancements:
resource_filename
withfiles
fromimportlib.resources
for improved resource handling.Build:
setup.py
andrequirements.txt
topyproject.toml
and Poetry for dependency management.CI:
Chores:
requirements.txt
,setup.py
,setup.cfg
,MANIFEST.in
,requirements_dev.txt
, andrequirements_docs.txt
.Makefile
to provide convenient commands for development tasks such as installing dependencies, running tests, and performing code quality checks.