Skip to content

Adds count and reverse #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adds count and reverse #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2b6599
Adds count and reverse
duksis Dec 8, 2016
9384789
Make internal functions private
duksis Dec 9, 2016
be440b5
Replace usage of odd?/1 with Integer.is_odd/1
duksis Dec 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions lib/list_ops.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,21 @@
defmodule ListOps do
def count([]) do
0
end

def count([_head | tail]) do
1 + count(tail)
end

def reverse(list) do
reverse(list, [])
end

defp reverse([], acumulator) do
acumulator
end

defp reverse([head | tail], acumulator) do
reverse(tail, [head | acumulator])
end
end
6 changes: 3 additions & 3 deletions test/list_ops_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,15 @@ defmodule ListOpsTest do
# end
#
# test "filter of empty list" do
# assert ListOps.filter([], &odd?/1) == []
# assert ListOps.filter([], &Integer.is_odd/1) == []
# end
#
# test "filter of normal list" do
# assert ListOps.filter([1,2,3,4], &odd?/1) == [1,3]
# assert ListOps.filter([1,2,3,4], &Integer.is_odd/1) == [1,3]
# end
#
# test "filter of huge list" do
# assert ListOps.filter(Enum.to_list(1..1_000_000), &odd?/1) ==
# assert ListOps.filter(Enum.to_list(1..1_000_000), &Integer.is_odd/1) ==
# Enum.map(1..500_000, &(&1*2-1))
# end
#
Expand Down