Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guava): update guava33.4.x #300

Merged
merged 1 commit into from
Feb 6, 2025
Merged

feat(guava): update guava33.4.x #300

merged 1 commit into from
Feb 6, 2025

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Feb 6, 2025

Summary

Updates the JPMS-enabled version of Guava to the current latest release (33.4.x), and patches the gson dependency to build against patched Guava during integration testing.

Relates to sgammon/guava#43 and google/guava#7094.

Changelog

  • chore: update gson to latest mainline revision
  • fix: usage of mvnw on linux while building bom
  • test: patch gson for testing guava integration

@sgammon sgammon added dependencies Related to dependency updates or issues ✋ embargoed Waiting for further action 🧪 labs Experimental work java Pull requests that update Java code labels Feb 6, 2025
@sgammon sgammon self-assigned this Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.26%. Comparing base (58db100) to head (a6f7b25).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files          32       32           
  Lines        7419     7419           
  Branches      442      442           
=======================================
  Hits         6771     6771           
  Misses        639      639           
  Partials        9        9           
Flag Coverage Δ
packages 91.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58db100...a6f7b25. Read the comment docs.

@sgammon sgammon force-pushed the chore/update-guava branch from 9eb3560 to a6f7b25 Compare February 6, 2025 00:37
@sgammon sgammon marked this pull request as ready for review February 6, 2025 01:15
@sgammon sgammon force-pushed the chore/update-guava branch from 68d0910 to fc3dc3b Compare February 6, 2025 02:02
Updates the JPMS-enabled version of Guava to the
current latest release (33.4.x), and patches the
`gson` dependency to build against patched Guava
during integration testing.

- feat(guava): update `guava` → `33.4.0` (trunk)
- fix: usage of `mvnw` on linux while building bom
- test: patch `gson` for testing guava integration
- chore: update `gson` to latest mainline revision
- chore: bump and rebuild catalog tools → `1.0.10`
- chore: update gradle catalog versions + lib pins

Signed-off-by: Sam Gammon <[email protected]>
@sgammon sgammon force-pushed the chore/update-guava branch from fc3dc3b to d7f1539 Compare February 6, 2025 02:04
@sgammon sgammon merged commit ba345cd into main Feb 6, 2025
7 of 8 checks passed
@sgammon sgammon deleted the chore/update-guava branch February 6, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to dependency updates or issues ✋ embargoed Waiting for further action java Pull requests that update Java code 🧪 labs Experimental work
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant