Performance improvement

elgentos · May 10, 2020 · 685d3c4 · 685d3c4
1 parent f7882a6
commit 685d3c4
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 22 deletions.
diff --git a/DataLayer/QuoteData/QuoteAbstract.php b/DataLayer/QuoteData/QuoteAbstract.php
@@ -9,10 +9,6 @@
 
 use Magento\Quote\Model\Quote;
 
-/**
- * Class QuoteAbstract
- * @package MagePal\GoogleTagManager\DataLayer\QuoteData
- */
 abstract class QuoteAbstract
 {
     /**

diff --git a/DataLayer/QuoteData/QuoteItemAbstract.php b/DataLayer/QuoteData/QuoteItemAbstract.php
@@ -9,10 +9,6 @@
 
 use Magento\Quote\Model\Quote\Item;
 
-/**
- * Class QuoteItemAbstract
- * @package MagePal\GoogleTagManager\DataLayer\QuoteData
- */
 abstract class QuoteItemAbstract
 {
     const LIST_TYPE_GOOGLE = 1;

diff --git a/DataLayer/QuoteData/QuoteItemProvider.php b/DataLayer/QuoteData/QuoteItemProvider.php
@@ -7,10 +7,6 @@
 
 namespace MagePal\GoogleTagManager\DataLayer\QuoteData;
 
-/**
- * Class QuoteItemProvider
- * @package MagePal\GoogleTagManager\DataLayer\QuoteData
- */
 class QuoteItemProvider extends QuoteItemAbstract
 {
     /**
@@ -29,13 +25,14 @@ public function __construct(
     public function getData()
     {
         $data =  $this->getItemData();
+        $arraysToMerge = [];
+
         /** @var QuoteItemAbstract $quoteItemProvider */
         foreach ($this->getQuoteItemProviders() as $quoteItemProvider) {
             $quoteItemProvider->setItem($this->getItem())->setItemData($data);
-
-            $data = array_merge($data, $quoteItemProvider->getData());
+            $arraysToMerge[] = $quoteItemProvider->getData();
         }
 
-        return $data;
+        return empty($arraysToMerge) ? $data : array_merge($data, ...$arraysToMerge);
     }
 }
diff --git a/DataLayer/QuoteData/QuoteProvider.php b/DataLayer/QuoteData/QuoteProvider.php
@@ -7,10 +7,6 @@
 
 namespace MagePal\GoogleTagManager\DataLayer\QuoteData;
 
-/**
- * Class QuoteProvider
- * @package MagePal\GoogleTagManager\DataLayer\QuoteData
- */
 class QuoteProvider extends QuoteAbstract
 {
     /**
@@ -29,13 +25,14 @@ public function __construct(
     public function getData()
     {
         $data =  $this->getTransactionData();
+        $arraysToMerge = [];
+
         /** @var QuoteAbstract $quoteProvider */
         foreach ($this->getQuoteProviders() as $quoteProvider) {
             $quoteProvider->setQuote($this->getQuote())->setTransactionData($data);
-
-            $data = array_merge($data, $quoteProvider->getData());
+            $arraysToMerge[] = $quoteProvider->getData();
         }
 
-        return $data;
+        return empty($arraysToMerge) ? $data : array_merge($data, ...$arraysToMerge);
     }
 }