Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions: Horizontally center media-playback-start #1233

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Actions: Horizontally center media-playback-start #1233

merged 2 commits into from
Jan 22, 2024

Conversation

danirabbit
Copy link
Member

Fixes #1232

@danirabbit danirabbit requested a review from newhoa September 20, 2023 16:34
jeremypw
jeremypw approved these changes Jan 22, 2024
View reviewed changes
Copy link

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty central to me when installed. Not sure if the best center is the geometrical one or just half the width but the difference is probably not visually significant at these sizes.

@danirabbit danirabbit merged commit baffa57 into main Jan 22, 2024
3 checks passed
@danirabbit danirabbit deleted the danirabbit/actions-play-centered branch January 22, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

@newhoa newhoa Awaiting requested review from newhoa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon inside the play button not in center
2 participants
@danirabbit @jeremypw