Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions: Refresh zoom icons at 16px #1218

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

newhoa
Copy link
Collaborator

@newhoa newhoa commented Jul 14, 2023

Use semi-transparent borders, use gradient for fill, add highlight inset border, adjust rounded edges to match curves of other similar action icons. Should look a little smoother. And sharper on dark backgrounds.


Current:
16px-zoom-current

Proposed:
16px-zoom-prop

Use semi-transparent borders, use gradient for fill,
add highlight inset border, adjust rounded edges to match
curves of other similar action icons.
@waldyrious
Copy link
Contributor

IMHO the current version has better contrast; not sure the highlight is a net positive. No opinion on the other changes, though I welcome improved sharpness in dark mode :)

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we lost quite a bit of border radius here compared to other tile icons at this size. I think I would base these on categories/16/applications-other to make sure we're being consistent there

While we're here, I wonder if we should change these glyphs to be more contrasty as well like:

Screenshot from 2023-07-17 10 36 10

@micahilbery
Copy link
Member

It looks like we lost quite a bit of border radius here compared to other tile icons at this size. I think I would base these on categories/16/applications-other to make sure we're being consistent there

While we're here, I wonder if we should change these glyphs to be more contrasty as well like:

Screenshot from 2023-07-17 10 36 10

The border is a big improvement, but I agree. I think they are too pointy now and I also agree that they should be more contrasty.

@newhoa newhoa marked this pull request as draft September 18, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants