Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Granite.Bin for subclassing #730

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Introduce Granite.Bin for subclassing #730

merged 1 commit into from
Sep 18, 2024

Conversation

leolost2605
Copy link
Member

We are now quite often doing an extension of widget and then setting the layout manager type to bin and doing all the other stuff with manually parenting and unparenting, so instead introduce Granite.Bin which holds only a single widget and is intended for subclassing. It's pretty much the same as Adw.Bin

@leolost2605 leolost2605 requested a review from a team September 18, 2024 22:39
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me!

@danirabbit danirabbit merged commit 77bf292 into main Sep 18, 2024
5 checks passed
@danirabbit danirabbit deleted the leolost/bin branch September 18, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants