-
-
Notifications
You must be signed in to change notification settings - Fork 115
Implement create new from template #1616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@danirabbit |
|
Now implemented a setting for user specified template folder |
|
On second thoughts, I think we ought to enter renaming mode so the actual desired name can be entered more conveniently. I'll implement this soon. |
|
Turns out there are some recalcitrant timing issues in starting to edit the source list after adding a new item to it. There does not seem to be an elegant way to reliably determine that the sourcelist is in a state where it can be edited (the available signals like |
This reverts commit abef963.
I don't think we should have a setting for the template folder, this should be using |
The idea is to keep Code specific templates separate (I am not sure why templates for different apps should all be in the same folder tbh). However, I'll bow to majority opinion and revert that. |
This reverts commit c91d1c3.
|
Need to check whether this is prone to the hanging bug found in Files when the templates folder is very large. |
Fixes #297
Adapted from Files code.
Some undecided issues:
(1) Should templates automatically enter rename mode (currrently not). I am assuming templates will be named something like "Application.vala" so will not need renaming.
(2) Should templates be automatically opened (currently not). I have kept the same behaviour as new file and folder but selected the new item so it can be easily opened if required.
(3) How to make where to put the template files more discoverable or configurable.