AppInfoView: redesign links #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryonakano
reviewed
Jun 22, 2024
Co-authored-by: Ryo Nakano <[email protected]>
Co-authored-by: Ryo Nakano <[email protected]>
ryonakano
reviewed
Jun 23, 2024
This comment was marked as resolved.
This comment was marked as resolved.
leolost2605
requested changes
Jun 23, 2024
|
Updated! I added description labels directly to the box here and also made sure to update the icon and a11y for stripe buttons. You can see here how it differs between a link and a payment that's handled by stripe:
|
leolost2605
approved these changes
Jun 25, 2024
ryonakano
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Maybe we can create the LinkRow class in Granite for consistent design, because the same design is used in elementary/switchboard-plug-about#325 too, but we can discuss that later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1134
Show more links, add some color. Group links related to contributing/giving vs requesting/contacting/receiving