Fix crash when deleting characters out of searches #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donadigo
approved these changes
Apr 7, 2017
|
I can confirm that this branch addresses the issue :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug that occurs when deleting characters out of searches.
It seems to be an issue with appstream where calling
component.get_custom_value (...)a second time, causes it to return something that was already freed from memory (probably a bug in appstream?). When the component gets deconstructed, it calls free on this object again and crashes.By moving the
payments_keyinto thePackageclass, it will only call that method once and prevent this crash.Fixes #202.