Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate ProgressButton from AbstractAppContainer #2125

Merged
merged 9 commits into from
Feb 22, 2024
Merged

Separate ProgressButton from AbstractAppContainer #2125

merged 9 commits into from
Feb 22, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Feb 16, 2024 •
edited
Loading

While we're here, use a Gtk.ProgressBar instead of custom CSS to draw progress

@danirabbit danirabbit marked this pull request as ready for review February 16, 2024 18:15
@danirabbit danirabbit requested a review from a team February 16, 2024 18:15
leolost2605
leolost2605 requested changes Feb 22, 2024
View reviewed changes
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really great, especially that you can now also see progress in the appinfoview. It has the same issue as the dropdown button though with the background becoming transparent when working.

@danirabbit
Copy link
Member Author

@leolost2605 good catch! Fixed :)

leolost2605
leolost2605 approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danirabbit danirabbit merged commit 9870890 into main Feb 22, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the danirabbit/progressbutton branch February 22, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leolost2605 leolost2605 leolost2605 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @leolost2605