show_uri → UriLauncher #2123
Merged
show_uri → UriLauncher #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryonakano
previously approved these changes
Feb 17, 2024
There was a problem hiding this comment.
Looks good and works as expected on Daily 8. Note that we can no longer release AppCenter for Horus after merging this branch.
If possible, we might want to update the docker image in the following line to development-target, to prevent the gettext actions from being failing, since the current next-unstable image points to horus-unstable
appcenter/.github/workflows/gettext.yml
Line 11 in 4052113
|
@ryonakano looks like it broke anyways. I proposed elementary/actions#81 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.