Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComponentValidator: drop hiddenapps function #2122

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

danirabbit
Copy link
Member

Closes #438

This is from a time when we were pulling apps from the Ubuntu repos and we had to specifically hide components that we didn't want to show like imagemagick and other utilities

@danirabbit danirabbit requested a review from a team February 16, 2024 03:50
@danirabbit danirabbit force-pushed the main branch 2 times, most recently from 6d20739 to 4052113 Compare February 16, 2024 15:56
@danirabbit danirabbit force-pushed the danirabbit/componentvalidate-drophiddenlist branch from b355c65 to 285ebb6 Compare February 16, 2024 18:30
@leolost2605
Copy link
Member

Maybe we could just make validate static and move it to Utils or something? Having a whole separate class for just a (static) method seems a bit overkill 🤷

@danirabbit danirabbit force-pushed the danirabbit/componentvalidate-drophiddenlist branch from d6836c2 to 6749487 Compare February 21, 2024 20:01
@danirabbit
Copy link
Member Author

@leolost2605 I moved it to BackendInterface since it's only used by the backends. How's that? :)

Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@danirabbit danirabbit merged commit 0cddaf3 into main Feb 22, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the danirabbit/componentvalidate-drophiddenlist branch February 22, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blacklist does not support comments
2 participants