Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateManager: Get complete update number #2104

Merged
merged 2 commits into from
Feb 7, 2024
Merged

UpdateManager: Get complete update number #2104

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11a21fd
Dont check for automatic updates when getting update number
leolost2605 Dec 29, 2023
cce2444
Merge branch 'master' into always-show-updates
danirabbit Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions src/Core/UpdateManager.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,6 @@ public class AppCenterCore.UpdateManager : Object {
var flatpak_updates = yield fp_client.get_updates ();
debug ("Flatpak backend reports %d updates", flatpak_updates.size);

var auto_update_enabled = AppCenter.App.settings.get_boolean ("automatic-updates");

foreach (var flatpak_update in flatpak_updates) {
var appcenter_package = fp_client.lookup_package_by_id (flatpak_update);
if (appcenter_package != null) {
Expand All @@ -125,11 +123,9 @@ public class AppCenterCore.UpdateManager : Object {
unpaid_apps_number++;
}

if (!auto_update_enabled || appcenter_package.should_pay) {
count++;
updates_size += appcenter_package.change_information.size;
has_flatpak_updates = true;
}
count++;
updates_size += appcenter_package.change_information.size;
has_flatpak_updates = true;

appcenter_package.change_information.updatable_packages.@set (fp_client, flatpak_update);
appcenter_package.update_state ();
Expand All @@ -153,10 +149,8 @@ public class AppCenterCore.UpdateManager : Object {
continue;
}

if (!AppCenter.App.settings.get_boolean ("automatic-updates")) {
runtime_count++;
has_flatpak_updates = true;
}
runtime_count++;
has_flatpak_updates = true;

runtime_desc += Markup.printf_escaped (
" • %s\n\t%s\n",
Expand Down