Changed named Gtk.Stack named icons to ref widget icons for performan…

…ce reasons
elementary · Jan 4, 2025 · 7b27f52 · 7b27f52
1 parent 17f4940
commit 7b27f52
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/src/Views/AppInfoView.vala b/src/Views/AppInfoView.vala
@@ -168,8 +168,8 @@ public class AppCenter.Views.AppInfoView : Adw.NavigationPage {
         var app_icon_stack = new Gtk.Stack () {
             transition_type = Gtk.StackTransitionType.CROSSFADE
         };
-        app_icon_stack.add_named (app_icon, "base_icon");
-        app_icon_stack.add_named (app_icon_updated, "updated_icon");
+        app_icon_stack.add_child (app_icon);
+        app_icon_stack.add_child (app_icon_updated);
 
         var app_icon_overlay = new Gtk.Overlay () {
             child = app_icon_stack,
@@ -198,7 +198,7 @@ public class AppCenter.Views.AppInfoView : Adw.NavigationPage {
             backend.on_metadata_remote_preprocessed.connect ((remote_title) => {
                 if (package.origin_description == remote_title) {
                     app_icon_updated.set_from_gicon (package.get_icon (128, scale_factor));
-                    app_icon_stack.visible_child_name = "updated_icon";
+                    app_icon_stack.visible_child = app_icon_updated;
                 }
             });
         }

diff --git a/src/Widgets/AppContainers/AbstractPackageRowGrid.vala b/src/Widgets/AppContainers/AbstractPackageRowGrid.vala
@@ -49,8 +49,8 @@ public abstract class AppCenter.Widgets.AbstractPackageRowGrid : Gtk.Box {
         image_stack = new Gtk.Stack () {
             transition_type = Gtk.StackTransitionType.CROSSFADE
         };
-        image_stack.add_named (icon_image, "base_icon");
-        image_stack.add_named (updated_icon_image, "updated_icon");
+        image_stack.add_child (icon_image);
+        image_stack.add_child (updated_icon_image);
 
         var badge_image = new Gtk.Image () {
             halign = Gtk.Align.END,
@@ -98,6 +98,6 @@ public abstract class AppCenter.Widgets.AbstractPackageRowGrid : Gtk.Box {
     public void update_icon (Icon icon) {
         updated_icon_image.clear ();
         updated_icon_image.set_from_gicon (icon);
-        image_stack.visible_child_name = "updated_icon";
+        image_stack.visible_child = updated_icon_image;
     }
 }
diff --git a/src/Widgets/Banner.vala b/src/Widgets/Banner.vala
@@ -106,8 +106,8 @@ public class AppCenter.Widgets.Banner : Gtk.Button {
         image_stack = new Gtk.Stack () {
             transition_type = Gtk.StackTransitionType.CROSSFADE,
         };
-        image_stack.add_named (icon_image, "base_icon");
-        image_stack.add_named (updated_icon_image, "updated_icon");
+        image_stack.add_child (icon_image);
+        image_stack.add_child (updated_icon_image);
 
         var inner_box = new Gtk.Box (VERTICAL, 0) {
             valign = CENTER
@@ -153,6 +153,6 @@ public class AppCenter.Widgets.Banner : Gtk.Button {
     public void update_icon (Icon icon) {
         uses_generic_icon = false;
         updated_icon_image.set_from_gicon (icon);
-        image_stack.visible_child_name = "updated_icon";
+        image_stack.visible_child = updated_icon_image;
     }
 }