Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update com.github.ztefn.haguichi to 1.151.0 #548

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

ztefn
Copy link
Contributor

@ztefn ztefn commented Feb 1, 2025

Rebased elementary branch on top of master, from commit d46f457 to c92a6f8.

Release tag: 1.151.0

The user interface has been completely rebuild utilizing GTK4 and libadwaita. Plus the user interface is now largely constructed using Gtk.Builder UI definitions instead of code.

This release also implements Xdp.Portal to request permission to run in the background.

In order to finally create this release for elementary OS i had to work my way around a bunch of issues in relation with support for GTK4 and libadwaita. I've done my best to report them all:

Review Checklist

  • App opens
  • Does what it says
  • Categories match

AppData

  • Name is unique and non-confusing
  • Matches description
  • Matches screenshot
  • Launchable tag with matching ID
  • Release tag with matching version and YYYY-MM-DD date
  • OARS info matches

Flatpak

  • Uses elementary runtime
  • Sandbox permissions are reasonable

@ztefn ztefn requested a review from a team as a code owner February 1, 2025 00:05
@ryonakano
Copy link
Member

The app itself looks good to me, but the CI is failing for some reason 🤔

/usr/bin/flatpak build-bundle repo com.github.ztefn.haguichi.flatpak --runtime-repo=https://flatpak.elementary.io/repo.flatpakrepo --arch=x86_64 com.github.ztefn.haguichi stable
Uploading artifact...
Starting artifact upload
For more detailed logs during the artifact upload process, enable step-debugging: https://docs.github.com/actions/monitoring-and-troubleshooting-workflows/enabling-debug-logging#enabling-step-debug-logging
Artifact name is valid!
Create Artifact Container - Error is not retryable
##### Begin Diagnostic HTTP information #####
Status Code: 400
Status Message: Bad Request
Header Information: {
  "content-length": "268",
  "content-type": "application/json; charset=utf-8",
  "date": "Sat, 01 Feb 2025 04:47:09 GMT",
  "server": "Kestrel",
  "cache-control": "no-store,no-cache",
  "pragma": "no-cache",
  "strict-transport-security": "max-age=2592000",
  "x-tfs-processid": "15ed339a-69cd-4cae-8260-db3e247bdd6d",
  "activityid": "eca2c705-0873-4ba9-82a1-000b6a50538d",
  "x-tfs-session": "eca2c705-0873-4ba9-82a1-000b6a50538d",
  "x-vss-e2eid": "eca2c705-0873-4ba9-82a1-000b6a50538d",
  "x-vss-senderdeploymentid": "2c974d96-2c30-cef5-eff2-3e0511a903a5",
  "x-frame-options": "SAMEORIGIN"
}
###### End Diagnostic HTTP information ######
##### Begin Diagnostic HTTP information #####
Status Code: 400
Status Message: Bad Request
Header Information: {
  "content-length": "268",
  "content-type": "application/json; charset=utf-8",
  "date": "Sat, 01 Feb 2025 04:47:09 GMT",
  "server": "Kestrel",
  "cache-control": "no-store,no-cache",
  "pragma": "no-cache",
  "strict-transport-security": "max-age=2592000",
  "x-tfs-processid": "15ed339a-69cd-4cae-8260-db3e247bdd6d",
  "activityid": "eca2c705-0873-4ba9-82a1-000b6a50538d",
  "x-tfs-session": "eca2c705-0873-4ba9-82a1-000b6a50538d",
  "x-vss-e2eid": "eca2c705-0873-4ba9-82a1-000b6a50538d",
  "x-vss-senderdeploymentid": "2c974d96-2c30-cef5-eff2-3e0511a903a5",
  "x-frame-options": "SAMEORIGIN"
}
###### End Diagnostic HTTP information ######
Error: Build failed: Error: Create Artifact Container failed: The artifact name com.github.ztefn.haguichi-x86_64 is not valid. Request URL https://pipelinesghubeus24.actions.githubusercontent.com/27kOXcXbm09kHxrFJEHB25mTfYcOg8anCtwtGzd2PXJ79lMxKT/_apis/pipelines/workflows/13082823958/artifacts?api-version=6.0-preview

Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the failing CI would be due to changes in this app because it also fails with he same error in another app submission (#545 ), so I'm approving this.
Edit: reported at #549

Nice updates!

@danirabbit
Copy link
Member

Gonna try force merging and hope the build publishes even though the review action is failing

@danirabbit danirabbit merged commit ba04b4f into elementary:main Feb 3, 2025
2 of 4 checks passed
@danirabbit
Copy link
Member

@ztefn thanks for reporting those issues! There are a couple things that you can do to further reduce the size of your branch and make things more maintainable for yourself in a future release:

AppStream has a way to filter screenshots by platform and even for dark and light modes and we handle it in AppCenter. Check out the section on setting environment here: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-screenshots

Instead of using an ifdef FOR_ELEMENTARY you can do GLib.Environment.get_variable ("XDG_CURRENT_DESKTOP") == "Pantheon" so your app will adjust for folks who are using Pantheon with your app on other distros too

@ztefn
Copy link
Contributor Author

ztefn commented Feb 4, 2025

@danirabbit Cool, i didn't know AppCenter already supports style properties on screenshots. Would be nice if AppCenter had a command line option similar to GNOME Software (--show-metainfo=FILENAME) to test out how specific metainfo data would be displayed.

@ryonakano
Copy link
Member

Would be nice if AppCenter had a command line option similar to GNOME Software (--show-metainfo=FILENAME) to test out how specific metainfo data would be displayed.

AppCenter has --load-local option for a while but it's broken in recent releases. For now, you can use it if your build and install elementary/appcenter#2231 from source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants