Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create io.github.ellie_commons.tomato #544

Merged
merged 9 commits into from
Jan 24, 2025
Merged

Conversation

alainm23
Copy link
Contributor

@alainm23 alainm23 commented Dec 26, 2024

Review Checklist

  • App opens
  • Does what it says
  • Categories match

AppData

  • Name is unique and non-confusing
  • Matches description
  • Matches screenshot
  • Launchable tag with matching ID
  • Release tag with matching version and YYYY-MM-DD date
  • Custom colors meet WCAG A contrast or greater We no longer check this
  • OARS info matches

Flatpak

  • Uses elementary runtime
  • Sandbox permissions are reasonable

image

https://github.com/ellie-commons/tomato

@alainm23 alainm23 requested a review from a team as a code owner December 26, 2024 17:42
@alainm23
Copy link
Contributor Author

@elementary/app-reviewers

@ryonakano ryonakano self-requested a review January 21, 2025 15:42
Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryonakano
Copy link
Member

Another thing I'm concerned is the app name: Tomato.

I think your app is fork/continuation of https://github.com/tomatoers/tomato, which was anciently available at AppCenter (maybe in 0.4 Loki). And you inherited the app name, which is potentially a problem if the original author changed their mind, come back to develop the app, and tried publishing the app on AppCenter again. While this wouldn't happen because the original repository has been archived, it's technically possible to unarchive their repository.
So I'm not sure if this is fine or not good.

@danirabbit Should we choose a different name for a forked app from the original app which is previously available on AppCenter?

@danirabbit
Copy link
Member

I think since it's archived and the original author hasn't tried to publish in all these years that's probably okay

@alainm23 alainm23 requested a review from ryonakano January 23, 2025 16:41
Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@elementary/app-reviewers I'm new to review app submissions. Feel free to review if I'm missing something.

@danirabbit danirabbit merged commit 1a223d1 into elementary:main Jan 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants