-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create io.github.ellie_commons.tomato #544
Conversation
@elementary/app-reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry for late review 🙇
I created the following issues as requested changes:
- desktop: flatpak-builder warns about matching "Desktop Action AboutDialog" group ellie-commons/tomato#2
- metainfo: flatpak-builder warns about release tags without date ellie-commons/tomato#3
- flatpak: Specify commit revision (and a tag or branch name) for reproducible build ellie-commons/tomato#4
I'd like you to address them.
Another thing I'm concerned is the app name: Tomato. I think your app is fork/continuation of https://github.com/tomatoers/tomato, which was anciently available at AppCenter (maybe in 0.4 Loki). And you inherited the app name, which is potentially a problem if the original author changed their mind, come back to develop the app, and tried publishing the app on AppCenter again. While this wouldn't happen because the original repository has been archived, it's technically possible to unarchive their repository. @danirabbit Should we choose a different name for a forked app from the original app which is previously available on AppCenter? |
I think since it's archived and the original author hasn't tried to publish in all these years that's probably okay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@elementary/app-reviewers I'm new to review app submissions. Feel free to review if I'm missing something.
Review Checklist
AppData
Custom colors meet WCAG A contrast or greaterWe no longer check thisFlatpak
https://github.com/ellie-commons/tomato