-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Detective to 1.1.0 #519
Update Detective to 1.1.0 #519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we probably explicitly don't want third party apps to be able to access Gala's desktop integration features as a matter of security. Especially not without like explicit consent. Apps not being able to focus themselves or see other running apps or windows on Wayland is a feature
I kinda disagree but I updated it :) |
It looks like it's still touching gala here? leolost2605/detective@1.0.2...08a3756 Accessing this interface without explicit user consent is a pretty serious privacy issue imo. If apps want to be able to read this kind of information, it needs to be through a portion where users can say no |
I'm not sure whether I missed something but the main part (i.e. DesktopIntegration.vala and the stuff that uses it) can (and is in the AppCenter version) be disabled via a meson build option, so that it's not even compiled in. |
Ah sorry I didn't catch that there was a meson flag there. Will re-review Monday! |
Release notes: https://github.com/leolost2605/detective/releases/tag/1.1.0
Review Checklist
AppData
Flatpak