Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Detective to 1.1.0 #519

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Jul 18, 2024

Release notes: https://github.com/leolost2605/detective/releases/tag/1.1.0

Review Checklist

  • App opens
  • Does what it says
  • Categories match

AppData

  • Name is unique and non-confusing
  • Matches description
  • Matches screenshot
  • Launchable tag with matching ID
  • Release tag with matching version and YYYY-MM-DD date
  • Custom colors meet WCAG A contrast or greater
  • OARS info matches

Flatpak

  • Uses elementary runtime
  • Sandbox permissions are reasonable

@leolost2605 leolost2605 requested a review from a team as a code owner July 18, 2024 10:06
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably explicitly don't want third party apps to be able to access Gala's desktop integration features as a matter of security. Especially not without like explicit consent. Apps not being able to focus themselves or see other running apps or windows on Wayland is a feature

@leolost2605
Copy link
Member Author

I kinda disagree but I updated it :)

@leolost2605 leolost2605 requested a review from danirabbit July 23, 2024 16:13
@danirabbit
Copy link
Member

It looks like it's still touching gala here? leolost2605/detective@1.0.2...08a3756

Accessing this interface without explicit user consent is a pretty serious privacy issue imo. If apps want to be able to read this kind of information, it needs to be through a portion where users can say no

@leolost2605
Copy link
Member Author

I'm not sure whether I missed something but the main part (i.e. DesktopIntegration.vala and the stuff that uses it) can (and is in the AppCenter version) be disabled via a meson build option, so that it's not even compiled in.

@danirabbit
Copy link
Member

Ah sorry I didn't catch that there was a meson flag there. Will re-review Monday!

@danirabbit danirabbit enabled auto-merge (squash) September 3, 2024 18:52
@danirabbit danirabbit merged commit 9a77f5c into elementary:main Sep 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants