Skip to content

Use hosts in rooms of the hierarchy for via parameter #18350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MatMaul
Copy link
Contributor

@MatMaul MatMaul commented Apr 17, 2025

Pull Request Checklist

Scenarii to reproduce:

  • user A on server A creates a space
  • user A creates a room in this space, with join restricted to the members of the space
  • user B on server B joins the space and the room
  • user A leaves the space and the room
  • user AB on server A joins the space
  • user AB can't see the room in the roomlist of the space
  • if an user on server A joins the room, the problem is solved

What is happening is that there is no valid via anymore for the room: it is not avail anymore on its original homeserver A, which is the only via available in the child event.

This PR gathers via parameters of all rooms of the hierarchy previously handled, and pass it to the fed endpoint when trying to fetch the remote hierarchy.

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@kfiven
Copy link
Contributor

kfiven commented Apr 28, 2025

Hi, I feel like you are trying to solve the same problem as in #18070 ?

@MatMaul
Copy link
Contributor Author

MatMaul commented May 6, 2025

Indeed. I am not sure they are contradictory however.

This change would still help if no valid via is passed by the client.

Opinions welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants