-
Notifications
You must be signed in to change notification settings - Fork 288
Add passthrough_authorization_parameters support to OIDC configuration #18232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
synapse/handlers/oidc.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be an extension of the spec, which should go through the spec change process. Given that it's unlikely that such a spec change would land, I think it would make sense to instead have a generic option to 'passthrough' specific query parameters.
Something like
oidc_providers:
- idp_id: …
passthrough_authorization_parameters:
- login_hint
And then passthrough any query parameter passed to /_matrix/client/v3/login/sso/redirect
to the OIDC authorization request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your inputs, makes sense, I've made the corresponding changes
login_hint
parameter in OIDC authentication flowThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty nice and short in the end, thanks for doing this!
Co-authored-by: Quentin Gliech <[email protected]>
@sandhose thanks 👍 |
Add passthrough_authorization_parameters support to OIDC configuration
This PR adds
the passthrough_authorization_parameters
option to OIDC configuration, allowing specific query parameters (likelogin_hint
) to be passed from the redirect endpoint to the authorization grant URL.This enables clients to provide additional context to identity providers during authentication flows.
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.(run the linters)