Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MSC4133 to support custom profile fields. #17488

Open
wants to merge 38 commits into
base: develop
Choose a base branch
from
Open

Implement MSC4133 to support custom profile fields. #17488

wants to merge 38 commits into from
+865 −23

Conversation

clokep
Copy link
Contributor

@clokep clokep commented Jul 25, 2024 •
edited
Loading

Implementation of MSC4133 to support custom profile fields. It is behind an experimental flag and includes tests.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@clokep clokep marked this pull request as ready for review July 26, 2024 00:00
@clokep clokep requested a review from a team as a code owner July 26, 2024 00:00
anoadragon453
anoadragon453 requested changes Jul 31, 2024
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but this is definitely on the right track. Thanks for implementing this!

synapse/handlers/profile.py Outdated Show resolved Hide resolved
synapse/handlers/profile.py Outdated Show resolved Hide resolved
synapse/handlers/profile.py Outdated Show resolved Hide resolved
synapse/handlers/profile.py Outdated Show resolved Hide resolved
synapse/handlers/sso.py Outdated Show resolved Hide resolved
synapse/rest/client/profile.py Show resolved Hide resolved
synapse/storage/databases/main/profile.py Outdated Show resolved Hide resolved
synapse/storage/databases/main/profile.py Outdated Show resolved Hide resolved
synapse/storage/schema/main/delta/86/01_custom_profile_fields.sql Outdated Show resolved Hide resolved
tests/rest/client/test_profile.py Outdated Show resolved Hide resolved
clokep and others added 4 commits July 31, 2024 07:25
@clokep @anoadragon453
Copy & paste error.
60b3f00 
Co-authored-by: Andrew Morgan <[email protected]>
@clokep @anoadragon453
Clarify docstring.
d2ab9c9 
Co-authored-by: Andrew Morgan <[email protected]>
@clokep
Correct license.
ce405ab
@clokep @anoadragon453
Fix typo.
e4f9d7e 
Co-authored-by: Andrew Morgan <[email protected]>
@tcpipuk tcpipuk mentioned this pull request Jul 31, 2024
Closed
@clokep
Copy link
Contributor Author

clokep commented Aug 9, 2024

I pushed some changes to update / flesh out the rest of the MSC, but I haven't yet gone through @anoadragon453's comments so not worth another review yet. (If folks want to test it that would be reasonable...I'm sure it'll break.)

@clokep clokep mentioned this pull request Aug 13, 2024
Merged
3 tasks
@clokep clokep changed the title Partially implement MSC4133 to support custom profile fields. Implement MSC4133 to support custom profile fields. Sep 9, 2024
@tcpipuk tcpipuk mentioned this pull request Sep 11, 2024
Open
@CLAassistant
Copy link

CLAassistant commented Oct 14, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@clokep
Copy link
Contributor Author

clokep commented Nov 7, 2024

I think this is close to ready for another review. There's a few open questions on the MSC that will affect this still.

@clokep clokep mentioned this pull request Dec 16, 2024
Merged
3 tasks
anoadragon453 pushed a commit that referenced this pull request Dec 19, 2024
@clokep
Remove support for PostgreSQL 11 and 12 (#18034)
2d23250 
This is essentially matrix-org/synapse#14392. I didn't see anything in
there about updating sytest or complement.

The main driver of this is so that I can use `jsonb_path_exists` in
#17488. 😄
@wcjord
Copy link

wcjord commented Dec 27, 2024

We're very excited to have this feature! What are the next steps?

@nexy7574 nexy7574 mentioned this pull request Dec 30, 2024
Merged
@clokep clokep mentioned this pull request Dec 31, 2024
Merged
3 tasks
@clokep
Copy link
Contributor Author

clokep commented Dec 31, 2024

We're very excited to have this feature! What are the next steps?

anoadragon453 pushed a commit that referenced this pull request Jan 3, 2025
@clokep
Refactor get_profile: do not return missing fields. (#18063)
6306de8 
Refactor `get_profile` to avoid returning "empty" (`None` / `null`)
fields. Currently this is not very important, but will be more useful
once #17488 lands. It does update the servlet to use this now which has
a minor change in behavior: additional fields served over federation
will now be properly sent back to clients.

It also adds constants for `avatar_url` / `displayname` although I did
not attempt to use it everywhere possible.
@clokep clokep requested a review from anoadragon453 January 3, 2025 19:13
@clokep
Copy link
Contributor Author

clokep commented Jan 3, 2025

@anoadragon453 This should be ready for another review. The commits definitely became very messy so unfortunately probably needs to be reviewed as a single change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcpipuk tcpipuk tcpipuk left review comments

@Half-Shot Half-Shot Half-Shot left review comments

@anoadragon453 anoadragon453 Awaiting requested review from anoadragon453

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@clokep @CLAassistant @wcjord @anoadragon453 @Half-Shot @tcpipuk