Clear the session cookie on logout from the GraphQL API #4328
+59
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
77b04ef
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://362e0caa.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-clear-cookie-graphq.matrix-authentication-service-docs.pages.dev |
reivilibre
approved these changes
Apr 14, 2025
sandhose
added
A-Account-Management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #4197 we show a 'session signed out' screen if we see a session cookie that has been finished.
This meant that you get the 'session ended' screen whenever you clicked 'sign out' within the frontend, which is quite weird.
This hacks things a little bit to make sure we clear the session cookie if we're logging out the current session