logout to upstream OIDC Provider when logging out from MAS #4249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcalinghee
force-pushed
the
feat/upstream_logout_end_session
branch
8 times, most recently
from
a2ac44f to
a53c9b4
Compare
mcalinghee
changed the title
mcalinghee
force-pushed
the
feat/upstream_logout_end_session
branch
3 times, most recently
from
695af90 to
0f90080
Compare
sandhose
requested changes
Apr 6, 2025
| .to_string(); | ||
| result.post_logout_redirect_uri = Some(post_logout_redirect_uri.clone()); | ||
|
|
||
| let sessions_cookie = UpstreamSessionsCookie::load(cookie_jar); |
There was a problem hiding this comment.
Loading from the cookie is unreliable. You should instead:
- lookup the authentications for the current
user_sessionin theuser_session_authentications - authentications that were done through an upstream will have a reference to a
upstream_oauth_authorization_session_id - there you can grab the
id_tokenreceived during the auth and extract the subject - you should also pass the id_token to the RP-initiated logout endpoint through the
id_token_hint
There was a problem hiding this comment.
Thank you for your review!
I have amended the code but I was not sure if I needed to extract the subject to perform the logout
| @@ -39,6 +41,22 @@ pub(crate) async fn post( | |||
| .record_browser_session(&clock, &session) | |||
| .await; | |||
|
|
|||
| // First, get RP-initiated logout endpoints before actually finishing the | |||
There was a problem hiding this comment.
We need to make sure that this logic also happens when the logout is done through the React frontend. I don't have a good suggestion on how to do so for now though
There was a problem hiding this comment.
mcalinghee
force-pushed
the
feat/upstream_logout_end_session
branch
4 times, most recently
from
d32d837 to
7defa02
Compare
mcalinghee
force-pushed
the
feat/upstream_logout_end_session
branch
2 times, most recently
from
bf1b470 to
8e1e912
Compare
mcalinghee
force-pushed
the
feat/upstream_logout_end_session
branch
from
8e1e912 to
648a390
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When logging out from MAS we would like to have the ability end the session on the upstream OIDC provider according to the spec : https://openid.net/specs/openid-connect-rpinitiated-1_0.html
If
allow_rp_initiated_logoutis set totrue, this will end the session on the upstream provider when logging out from MAS.