-
Notifications
You must be signed in to change notification settings - Fork 220
Revert "Add a banner to encrypted rooms with visible history. (#4738)" #4850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@stefanceriu asked for a complete revert for now, updated in 072e7f5 |
Generated by 🚫 Danger Swift against 072e7f5 |
|
stefanceriu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do it!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4850 +/- ##
===========================================
- Coverage 79.37% 79.28% -0.09%
===========================================
Files 888 888
Lines 85363 85311 -52
===========================================
- Hits 67754 67640 -114
- Misses 17609 17671 +62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Successor: #4851 |



This PR doesn't fix the underlying bug but hides it for anyone not testing the new feature.