Skip to content

Conversation

@pixlwave
Copy link
Member

@pixlwave pixlwave commented Dec 12, 2025

This PR doesn't fix the underlying bug but hides it for anyone not testing the new feature.

@pixlwave pixlwave requested a review from a team as a code owner December 12, 2025 11:09
@pixlwave pixlwave requested review from Velin92 and removed request for a team December 12, 2025 11:09
@pixlwave pixlwave added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Dec 12, 2025
@pixlwave
Copy link
Member Author

pixlwave commented Dec 12, 2025

@stefanceriu asked for a complete revert for now, updated in 072e7f5

@github-actions
Copy link

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 072e7f5

@pixlwave pixlwave added pr-bugfix for bug fix and removed pr-wip for anything that isn't ready to ship and will be enabled at a later date labels Dec 12, 2025
@pixlwave pixlwave changed the title Put the history visibility banner behind the feature flag and fix some formatting. Revert "Add a banner to encrypted rooms with visible history. (#4738)" Dec 12, 2025
@sonarqubecloud
Copy link

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do it!

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.28%. Comparing base (00b2895) to head (072e7f5).
⚠️ Report is 3 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4850      +/-   ##
===========================================
- Coverage    79.37%   79.28%   -0.09%     
===========================================
  Files          888      888              
  Lines        85363    85311      -52     
===========================================
- Hits         67754    67640     -114     
- Misses       17609    17671      +62     
Flag Coverage Δ
unittests 70.63% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 2eb02cd into develop Dec 12, 2025
17 checks passed
@pixlwave pixlwave deleted the doug/history-visibility branch December 12, 2025 11:44
@kaylendog
Copy link
Contributor

kaylendog commented Dec 12, 2025

Successor: #4851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix for bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants