Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme.md and some other markdown files. #970

Merged
merged 21 commits into from
Jul 27, 2023
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jul 26, 2023

@bmarty bmarty requested a review from a team as a code owner July 26, 2023 15:22
@bmarty bmarty requested review from ganfra and removed request for a team July 26, 2023 15:22
Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link:

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9c63a22) 56.65% compared to head (7180e7f) 56.65%.
Report is 20 commits behind head on develop.

❗ Current head 7180e7f differs from pull request most recent head 4fcc45a. Consider uploading reports for the commit 4fcc45a to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #970   +/-   ##
========================================
  Coverage    56.65%   56.65%           
========================================
  Files          978      978           
  Lines        24732    24732           
  Branches      5012     5012           
========================================
  Hits         14012    14012           
  Misses        8501     8501           
  Partials      2219     2219           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manuroe
Copy link
Member

manuroe commented Jul 26, 2023

Should we add a link to #911 to share the state?
It can replace "This app is currently in a pre-alpha release stage with only basic functionalities.". The app has not all feature of EA but what we have work.

I wonder if we should have a link to https://element.io/blog/element-x-experience-the-future-of-element/ to illustrate the story behind EX.

@bmarty
Copy link
Member Author

bmarty commented Jul 26, 2023

Should we add a link to #911 to share the state? It can replace "This app is currently in a pre-alpha release stage with only basic functionalities.". The app has not all feature of EA but what we have work.

I added the link in the "Status" section: https://github.com/vector-im/element-x-android/pull/970/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R59

I wonder if we should have a link to https://element.io/blog/element-x-experience-the-future-of-element/ to illustrate the story behind EX.

Yes, could point, will do.

@bmarty
Copy link
Member Author

bmarty commented Jul 27, 2023

I have added 4fcc45a . I am merging the PR, of course we can still iterate on those files regularly.

@bmarty bmarty merged commit ede935c into develop Jul 27, 2023
@bmarty bmarty deleted the feature/bma/readme branch July 27, 2023 11:05
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Readme
3 participants