Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log. #4203

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Remove log. #4203

merged 1 commit into from
Jan 27, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jan 27, 2025

Content

Remove log, it was debug log.

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner January 27, 2025 17:41
@bmarty bmarty requested review from ganfra and removed request for a team January 27, 2025 17:41
@bmarty bmarty added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Jan 27, 2025
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/wKwike

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.18%. Comparing base (23e2caa) to head (2a341b2).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4203      +/-   ##
===========================================
- Coverage    80.18%   80.18%   -0.01%     
===========================================
  Files         2023     2023              
  Lines        53282    53280       -2     
  Branches      6451     6451              
===========================================
- Hits         42725    42723       -2     
  Misses        8339     8339              
  Partials      2218     2218              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ganfra ganfra merged commit 9e5c5fa into develop Jan 27, 2025
30 checks passed
@ganfra ganfra deleted the feature/bma/removeLog branch January 27, 2025 21:44
@bmarty bmarty added the PR-Misc For other changes label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants