Media Viewer: show snackbar when reaching end of timeline. #4201
Conversation
bmarty
added
the
PR-Wip
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4201 +/- ##
========================================
Coverage 83.35% 83.36%
========================================
Files 1886 1886
Lines 49404 49437 +33
Branches 5804 5811 +7
========================================
+ Hits 41181 41213 +32
Misses 6134 6134
- Partials 2089 2090 +1 ☔ View full report in Codecov by Sentry. |
| @@ -64,6 +72,37 @@ class MediaViewerPresenter @AssistedInject constructor( | |||
| var currentIndex by remember { mutableIntStateOf(searchIndex(data, inputs.eventId)) } | |||
| val snackbarMessage by snackbarDispatcher.collectSnackbarMessageAsState() | |||
|
|
|||
| val isRenderingLoadingBackward by remember { | |||
There was a problem hiding this comment.
This will cause the the Present method to recompose, I think you should try to manage this only using snapshot flows inside the LaunchedEffect.
Maybe also extract that into a separate method.
There was a problem hiding this comment.
I have extracted to sub method. For the recomposition issue can we handle it later?
|
Content
Media Viewer: show snackbar when reaching end of timeline.
When the loading page is displayed and there is no more media to load, the loading page vanished (this is handled automatically by the HorizontalPager - without animation (is does not seem to be supported yet by the library) and a Snackbar is displayed. This PR handle the displaying of the snackbar.
Motivation and context
Follow design from Figma https://www.figma.com/design/Ni6Ii8YKtmXCKYNE90cC67/Timeline-(new)?node-id=2660-29699&m=dev
Screenshots / GIFs
Tests
Tested devices
Checklist