-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix snack bar not displayed in MediaViewer #4195
Conversation
…s displayed in the current screen (#4128)
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4195 +/- ##
========================================
Coverage 83.35% 83.35%
========================================
Files 1886 1886
Lines 49403 49404 +1
Branches 5804 5804
========================================
+ Hits 41180 41181 +1
Misses 6134 6134
Partials 2089 2089 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, LGTM
Content
The SnackBar was not displayed in the MediaViewer because it's in a Node which is displayed in Overlay mode. In this case, the Screen below (Messages or Gallery) is consuming the SnackBar. Using a local
SnackbarDispatcher
inMediaViewerPresenter
fixes the issue. This is commit d36b413c3e148b is closing the bottom sheet once an action is selected, to either leave space for the share native bottom sheet or the "saved" snackbar.
Other commits are cleanup.
Motivation and context
Closes #4128
Screenshots / GIFs
SaveSnackBar.mp4
Tests
Tested devices
Checklist