Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kover: include back :libraries:matrix:impl module. #4193

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jan 24, 2025

Content

Kover: include back :libraries:matrix:impl module.

Motivation and context

We want to track which code is not tested in this module.

We expect a decrease in the coverage

image

Screenshots / GIFs

NA

Tests

NA

Tested devices

NA

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner January 24, 2025 08:18
@bmarty bmarty requested review from ganfra and removed request for a team January 24, 2025 08:18
@bmarty bmarty marked this pull request as draft January 24, 2025 08:18
@bmarty bmarty removed the request for review from ganfra January 24, 2025 08:18
Copy link
Contributor

github-actions bot commented Jan 24, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/dqxHAM

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.17%. Comparing base (3668e86) to head (8a1e530).
Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4193      +/-   ##
===========================================
- Coverage    83.35%   80.17%   -3.18%     
===========================================
  Files         1886     2023     +137     
  Lines        49403    53248    +3845     
  Branches      5804     6444     +640     
===========================================
+ Hits         41180    42692    +1512     
- Misses        6134     8339    +2205     
- Partials      2089     2217     +128     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty force-pushed the feature/bma/coverage branch from ecd8123 to 8a1e530 Compare January 27, 2025 08:56
@bmarty bmarty changed the title wip Kover: include back :libraries:matrix:impl module. Jan 27, 2025
@bmarty bmarty added the PR-Build For changes related to build, tools, CI/CD label Jan 27, 2025
@bmarty bmarty marked this pull request as ready for review January 27, 2025 08:58
@bmarty bmarty merged commit af5491b into develop Jan 27, 2025
28 of 29 checks passed
@bmarty bmarty deleted the feature/bma/coverage branch January 27, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant