-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links open in in-app browser #3885
Comments
I am getting into the habit of always clicking on an hamburger menu to open the full browser but it's an extra step for basically every link I tap on. |
This web browser behavior is due to the use of Chrome Custom Tabs. Both Chrome and Firefox act as custom tab providers, and neither browser permits this behavior to be disabled anymore. Custom tabs are great for OIDC authentication flows and such, but I believe that using them for general web links is not ideal. In-app browsers, and the remote tab apps which mimic them, are usually considered an anti-feature. They do not offer the user's other tabs, bookmarks, search, or an editable URL bar. The "back" button returns the user to the app—not to their browser or the previous page they were looking at. These are all design patterns which hold users "captive" within an app—usually to drive engagement and ad impressions. Obviously, this is not what Element X is after. Are there other compelling reasons to use Custom Tabs? Element Android classic did not work this way. Very frequently I want to background a tab so I can read it later, at my leisure. Opening a full tab in my full web browser should be one tap, not three. On a large phone with small hands, those last two taps can be hard targets. If I want to return to Element from my full browser, I can just double-tap the Overview button. That's an action I am very accustomed to, in all sorts of apps, but it actually doesn't work correctly within the Custom Tab. |
In [1], all hyperlinks within `MessagesNode` switched to using activity.openUrlInChromeCustomTab() instead of with `openUrlInExternalApp()`. This causes web links in chat messages to open in an "in-app" Chrome Custom Tab [2] instead of the user's configured "full" web browser. This is a UX nuisance. Open web links in a full browser instead. Closes element-hq#3885 [3]. [1]: 5baefd4 (Identity change: handle click on "learn more") [2]: https://developer.chrome.com/docs/android/custom-tabs/guide-get-started#opening_a_custom_tab [3]: element-hq#3885
In [1], all hyperlinks within `MessagesNode` switched to using activity.openUrlInChromeCustomTab() instead of with `openUrlInExternalApp()`. This causes web links in chat messages to open in an "in-app" Chrome Custom Tab [2] instead of the user's configured "full" web browser. This is a UX nuisance. Open web links in a full browser instead. Closes element-hq#3885 [3]. [1]: 5baefd4 (Identity change: handle click on "learn more") [2]: https://developer.chrome.com/docs/android/custom-tabs/guide-get-started#opening_a_custom_tab [3]: element-hq#3885
Steps to reproduce
Click on a link in the chat
Outcome
What did you expect?
Link opens in external browser
What happened instead?
Link opens in some sort of in-app web view. This is okayyyyy (if ugly), but the real problem is that there is no way to keep the web view open if I want to go back to chatting.
Your phone model
Samsung S22
Operating system version
Android 14
Application version and app store
0.7.3-nithgly 666cedd
Homeserver
No response
Will you send logs?
No
Are you willing to provide a PR?
No
The text was updated successfully, but these errors were encountered: